Add Meter Palette Tests (Beginner and Advanced)#5890
Closed
021nirav-blip wants to merge 2 commits intosugarlabs:masterfrom
Closed
Add Meter Palette Tests (Beginner and Advanced)#5890021nirav-blip wants to merge 2 commits intosugarlabs:masterfrom
021nirav-blip wants to merge 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
1 similar comment
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
021nirav-blip
force-pushed
the
expand-test-suite-meter-palette
branch
from
50e3735 to
5a1b601
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
- Add comprehensive test coverage for Meter palette blocks - Meter Palette Tests Beginner: meter, beat count, whole notes played, notes played, BPM - Meter Palette Tests Advanced: current meter, beat factor, measure count, note counter, on strong beat, pickup - Increase test suite coverage from 25% to include Meter palette - Follow existing test patterns with proper compare test framework - Add 62 new test blocks to test-suite.html Fixes part of sugarlabs#5607
- Update .nvmrc from 20 to 22 - Matches CI Node.js requirement (>=22.12.0) - Fixes EBADENGINE warnings in npm ci
021nirav-blip
force-pushed
the
expand-test-suite-meter-palette
branch
from
5a1b601 to
c1536f2
Compare
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
Author
|
"The failing tests (palette.test.js, logo.test.js, logoconstants.test.js) are pre-existing failures unrelated to Meter Palette Tests changes" |
Contributor
|
Duplicate of PR #5614 .please close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #5607
@walterbender
@vanshika2720